Introduce a Dockerized version of the tool + Add support of generating YAML files as an output #2
Conversation
| end | ||
| puts changelog_yaml | ||
|
|
||
| changelog_path = ENV["CHANGELOG_YAML_PATH"] |
There was a problem hiding this comment.
For consistency with the previous behavior would be preferable as an optional additional argument.
Alternatively, and this seems preferable, shouldn't this be the job of the invoker, i.e. docker-runner.rb?
There was a problem hiding this comment.
Then you would need to parse the CLI output there which is not fun.
Regarding optional arguments, it requires adding a CLI arguments framework to do it well. I could do it, but IMHO it is a separate story since the tool already uses environment variables in the script. Subject for further improvement
| changelog_yaml = backported_issues.to_yaml | ||
| puts changelog_yaml | ||
|
|
||
| changelog_path = ENV["CHANGELOG_YAML_PATH"] |
There was a problem hiding this comment.
Same as above, seems to make more sense as an argument.
Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
oleg-nenashev
changed the title
|
@daniel-beck @MarkEWaite ready for final review IMHO |
oleg-nenashev
changed the title
oleg-nenashev
changed the title
|
i will merge it to setup a CD Pipeline for the tool |
@daniel-beck @MarkEWaite . I am experimenting with a Dockerized version of the tool for automated changelog generation with a GitHub Actions PoC. This PR kinda works, but it is in progress for now