Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-73175] Expose exception for invalid reports #113

Merged
merged 8 commits into from
Jun 7, 2024
Merged

[JENKINS-73175] Expose exception for invalid reports #113

merged 8 commits into from
Jun 7, 2024

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Jun 6, 2024 •
edited
Loading

When there are duplicate elements in Cobertura reports, then the parser throws an exception. It is already possible to ignore the exception and throw away the duplicate elements. But it would make more sense to retain those duplicate elements and use a generated name.

For more details see JENKINS-73175.

@uhafner uhafner added the enhancement Enhancement of existing functionality label Jun 6, 2024
@uhafner uhafner marked this pull request as draft June 6, 2024 09:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 291 passed)
   〰️   Line Coverage: 98% (49 missed lines)
   ➰   Branch Coverage: 94% (51 missed branches)
   PIT   Mutation Coverage: 93% (75 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No warnings
   🐛   Error Prone: 73 warnings (0 error, 0 high, 73 normal, 0 low)

Created by Quality Monitor v1.9.0 (#00b9b1a). More details are shown in the GitHub Checks Result.

@uhafner
Use a composed key for files as key.
c6e6915 
Files are identified by path and name so the key should take both
properties into account.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 291 passed)
   〰️   Line Coverage: 98% (49 missed lines)
   ➰   Branch Coverage: 94% (51 missed branches)
   PIT   Mutation Coverage: 93% (75 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No warnings
   🐛   Error Prone: 73 warnings (0 error, 0 high, 73 normal, 0 low)

Created by Quality Monitor v1.9.0 (#00b9b1a). More details are shown in the GitHub Checks Result.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 291 passed)
   〰️   Line Coverage: 98% (49 missed lines)
   ➰   Branch Coverage: 94% (51 missed branches)
   PIT   Mutation Coverage: 93% (75 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No warnings
   🐛   Error Prone: 73 warnings (0 error, 0 high, 73 normal, 0 low)

Created by Quality Monitor v1.9.0 (#00b9b1a). More details are shown in the GitHub Checks Result.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 291 passed)
   〰️   Line Coverage: 98% (49 missed lines)
   ➰   Branch Coverage: 94% (51 missed branches)
   PIT   Mutation Coverage: 93% (75 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No warnings
   🐛   Error Prone: 73 warnings (0 error, 0 high, 73 normal, 0 low)

Created by Quality Monitor v1.9.0 (#00b9b1a). More details are shown in the GitHub Checks Result.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 291 passed)
   〰️   Line Coverage: 98% (49 missed lines)
   ➰   Branch Coverage: 94% (51 missed branches)
   PIT   Mutation Coverage: 93% (75 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No warnings
   🐛   Error Prone: 73 warnings (0 error, 0 high, 73 normal, 0 low)

Created by Quality Monitor v1.9.0 (#00b9b1a). More details are shown in the GitHub Checks Result.

@uhafner uhafner marked this pull request as ready for review June 7, 2024 09:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 296 passed)
   〰️   Line Coverage: 98% (47 missed lines)
   ➰   Branch Coverage: 94% (51 missed branches)
   PIT   Mutation Coverage: 93% (75 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No warnings
   🐛   Error Prone: 75 warnings (0 error, 0 high, 75 normal, 0 low)

Created by Quality Monitor v1.9.0 (#00b9b1a). More details are shown in the GitHub Checks Result.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 296 passed)
   〰️   Line Coverage: 98% (47 missed lines)
   ➰   Branch Coverage: 94% (51 missed branches)
   PIT   Mutation Coverage: 93% (75 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No warnings
   🐛   Error Prone: 76 warnings (0 error, 0 high, 76 normal, 0 low)

Created by Quality Monitor v1.9.0 (#00b9b1a). More details are shown in the GitHub Checks Result.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 296 passed)
   〰️   Line Coverage: 98% (47 missed lines)
   ➰   Branch Coverage: 94% (51 missed branches)
   PIT   Mutation Coverage: 93% (75 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No warnings

Created by Quality Monitor v1.9.0 (#00b9b1a). More details are shown in the GitHub Checks Result.

@uhafner uhafner merged commit 4b44c0c into main Jun 7, 2024
28 checks passed
@uhafner uhafner deleted the autogenerate-names branch June 7, 2024 14:58
@uhafner uhafner mentioned this pull request Jun 7, 2024
Merged
uhafner added a commit that referenced this pull request Jun 25, 2024
@uhafner
JENKINS-73325: Use ID when merging nodes.
060a837 
Followup to #113
@uhafner uhafner mentioned this pull request Jun 25, 2024
Merged
uhafner added a commit that referenced this pull request Jun 25, 2024
@uhafner
JENKINS-73325: Use ID when merging nodes.
046e965 
Followup to #113
uhafner added a commit that referenced this pull request Jun 25, 2024
@uhafner
JENKINS-73325: Use ID when merging nodes (#117)
f469b83 
JENKINS-73325: Use ID when merging nodes.

Followup to #113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@uhafner