Merge all values of the hierarchy using max

[uhafner]

See jenkinsci/code-coverage-api-plugin#729

Tasks to do:

• Replace add with max for inner nodes as well
• Implement merging of package splitting

[Kirdock]

With this functionality it's still a replace right? It just takes the coverage that's higer.
If there is a file with the functions a and b, coverage X covers func a and coverage Y covers function b, it's 50% overall coverage instead of 100% right?

[uhafner]

It is still not clear on how to merge inner nodes 😞

The code works for leaves but not for inner nodes yet. I can drop the details of inner nodes and compute them on my own but that will cause other problems...

Do you have an idea on how to implement this correctly? I do not see a solution for this problem.

[Kirdock]

I don't have much experience with coverage reports, but by just looking at the cobertura one, I would expect that the lines should be merged (identified by number and branch) and hits > 0 should be preferred

[uhafner]

After adding some more tests it looks that the merge using max is working correctly.

With this functionality it's still a replace right? It just takes the coverage that's higer.
If there is a file with the functions a and b, coverage X covers func a and coverage Y covers function b, it's 50% overall coverage instead of 100% right?

No, since each file has a coverage for X and Y. So X contains a=100% and b=0%, and Y contains a=0% and b=100%, then the max will produce a=100% and b=100%.

[Kirdock]

I mean it's more correct than before.
Lets say we have function A.

function A(flag: boolean) {
  if(flag) {
    console.log('true');
  } else {
   console.log('false');
  }
}

If you have two separate coverage reports, one with the file x.spec.test that tests A only with true and one with the file y.spec.test that tests A only with false, then both of them would have the same coverage (about 50%) and the code-coverage-api would return 50% right?

[uhafner]

I mean it's more correct than before. Lets say we have function A.

function A(flag: boolean) {
  if(flag) {
    console.log('true');
  } else {
   console.log('false');
  }
}

If you have two separate coverage reports, one with the file x.spec.test that tests A only with true and one with the file y.spec.test that tests A only with false, then both of them would have the same coverage (about 50%) and the code-coverage-api would return 50% right?

No, the coverage is not measured per method, it is line based. The coverage per method is computed from the line coverage. So you should get a 100% coverage in total.

[codecov]

Codecov Report

Merging #27 (9057752) into main (03bf2f9) will increase coverage by 0.05%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##               main      #27      +/-   ##
============================================
+ Coverage     85.91%   85.96%   +0.05%     
  Complexity      492      492              
============================================
  Files            23       23              
  Lines          1356     1361       +5     
  Branches        194      193       -1     
============================================
+ Hits           1165     1170       +5     
+ Misses          145      144       -1     
- Partials         46       47       +1     

Files Changed	Coverage Δ
.../main/java/edu/hm/hafner/coverage/PackageNode.java	100.00% <ø> (ø)
src/main/java/edu/hm/hafner/coverage/Node.java	82.38% <88.88%> (+0.51%)	⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more