Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maximum complexity of all methods as a metric #5

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Mar 30, 2023

Summing up the complexities of all methods might be not a good metric for a project. It makes more sense to look at the maximum complexity of all methods.

@uhafner uhafner added the feature New features label Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #5 (cf859d3) into main (55e9852) will decrease coverage by 0.17%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main       #5      +/-   ##
============================================
- Coverage     85.40%   85.23%   -0.17%     
- Complexity      476      478       +2     
============================================
  Files            23       23              
  Lines          1302     1321      +19     
  Branches        187      193       +6     
============================================
+ Hits           1112     1126      +14     
- Misses          145      150       +5     
  Partials         45       45              
Impacted Files Coverage Δ
src/main/java/edu/hm/hafner/coverage/Value.java 29.03% <ø> (ø)
src/main/java/edu/hm/hafner/coverage/Metric.java 89.18% <60.00%> (+0.66%) ⬆️
src/main/java/edu/hm/hafner/coverage/Node.java 80.99% <100.00%> (-1.34%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@uhafner uhafner merged commit 9b1576e into main Mar 30, 2023
@uhafner uhafner deleted the complexity-max branch March 30, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant