Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relative path for file nodes #8

Merged
merged 13 commits into from
Apr 9, 2023
Merged

Add relative path for file nodes #8

merged 13 commits into from
Apr 9, 2023

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Apr 4, 2023

Replaces the path computation based on packages.

Fixes jenkinsci/code-coverage-api-plugin#610

Tasks:

  • Optimize TreeString creation

Replaces the path computation based on packages.
@uhafner uhafner added the bug Bugs or performance problems label Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #8 (8b5348d) into main (b39b053) will increase coverage by 0.36%.
The diff coverage is 93.10%.

@@             Coverage Diff              @@
##               main       #8      +/-   ##
============================================
+ Coverage     85.15%   85.52%   +0.36%     
+ Complexity      481      480       -1     
============================================
  Files            23       23              
  Lines          1334     1340       +6     
  Branches        195      190       -5     
============================================
+ Hits           1136     1146      +10     
+ Misses          152      148       -4     
  Partials         46       46              
Impacted Files Coverage Δ
...in/java/edu/hm/hafner/coverage/CoverageParser.java 61.90% <71.42%> (+4.76%) ⬆️
...edu/hm/hafner/coverage/parser/CoberturaParser.java 89.07% <80.00%> (-1.11%) ⬇️
src/main/java/edu/hm/hafner/coverage/FileNode.java 91.11% <100.00%> (+0.57%) ⬆️
...c/main/java/edu/hm/hafner/coverage/ModuleNode.java 100.00% <100.00%> (ø)
src/main/java/edu/hm/hafner/coverage/Mutation.java 79.31% <100.00%> (+0.24%) ⬆️
src/main/java/edu/hm/hafner/coverage/Node.java 81.86% <100.00%> (+0.86%) ⬆️
.../main/java/edu/hm/hafner/coverage/PackageNode.java 100.00% <100.00%> (+12.00%) ⬆️
...va/edu/hm/hafner/coverage/parser/JacocoParser.java 90.13% <100.00%> (+0.26%) ⬆️
...va/edu/hm/hafner/coverage/parser/PitestParser.java 97.50% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@uhafner uhafner marked this pull request as ready for review April 5, 2023 21:50
@uhafner uhafner marked this pull request as draft April 5, 2023 21:50
* @throws ParsingException
* if the XML content cannot be read
*/
protected abstract ModuleNode parseReport(Reader reader, FilteredLog log);

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'log' is never used.
@uhafner uhafner marked this pull request as ready for review April 6, 2023 12:06
@uhafner uhafner merged commit 5269b82 into main Apr 9, 2023
@uhafner uhafner deleted the missing-files branch April 9, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some files are not painted from cobertura report
1 participant