Correctly merge test cases into the existing coverage tree

[uhafner]

The mapping is done by evaluating the name of the test class. If the name of the test class cannot be mapped to a target class, then the tests of this test class are ignored. All unmapped test classes will be retained so that they can be visualized differently.

[github-actions]

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 291 passed)
   〰️   Line Coverage: 98% (49 missed lines)
   ➰   Branch Coverage: 94% (51 missed branches)
     Mutation Coverage: 93% (75 survived mutations)
     CheckStyle: No warnings found
     PMD: No warnings found
     SpotBugs: No warnings found

Created by Quality Monitor v1.7.0 (#823c682). More details are shown in the GitHub Checks Result.

[uhafner]

Required for jenkinsci/coverage-plugin#118

[jonesbusy]

Hi,

I think this cause some regression for me

05:42:26.799+02:00] - Error when executing always post condition:
[05:42:26.818+02:00] - Also:   org.jenkinsci.plugins.workflow.actions.ErrorAction$ErrorId: b9f1eb15-fe39-4322-bf2a-b2b681bda2a6
[05:42:26.818+02:00] - java.lang.IllegalArgumentException: There is already a child [PACKAGE] - <0> with the name - in [CONTAINER] Container <2, LINE: 9.54% (25/262)>
[05:42:26.818+02:00] - 	at edu.hm.hafner.coverage.Node.addChild(Node.java:167)
[05:42:26.818+02:00] - 	at io.jenkins.plugins.coverage.metrics.steps.CoverageRecorder.createPackage(CoverageRecorder.java:565)
[05:42:26.818+02:00] - 	at io.jenkins.plugins.coverage.metrics.steps.CoverageRecorder.lambda$mapTests$6(CoverageRecorder.java:560)
[05:42:26.818+02:00] - 	at java.base/java.util.Optional.orElseGet(Unknown Source)

I'm doing something like

recordCoverage(
 tools: [
   [parser: 'JACOCO', pattern: 'backend/target/site/jacoco/jacoco.xml'],
   [parser: 'COBERTURA', pattern: 'frontend/coverage/cobertura-coverage.xml'],
   [parser: 'JUNIT', pattern: 'backend/target/surefire-reports/TEST-*.xml,backend/target/failsafe-reports/TEST-*.xml,frontend/junit.xml']
        ],
        failOnError: false

I was checking my report they don't have duplicate, they are too different application and techo.

Not sure what's going on there

The frontend/junit.xml looks like this

<?xml version="1.0" encoding="UTF-8"?>
<testsuites name="jest tests" tests="1" failures="0" errors="0" time="2.395">
  <testsuite name="Todo" errors="0" failures="0" skipped="0" timestamp="2024-04-26T04:27:11" time="1.927" tests="1">
    <testcase classname="Todo should correctly set properties" name="Todo should correctly set properties" time="0.004">
    </testcase>
  </testsuite>
</testsuites>

And using something like to generate the JUNIT format

JEST_SONAR_OUTPUT_DIR=sonar-results jest --coverage --coverageDirectory=coverage --reporters=default --reporters=jest-junit --reporters=jest-sonar

I confirm if I remove the frontend/junit.xml I can execute the coverage.

Before the update of the plugin I was able to get a test report.

I'm wondering if it's related to the '-' package name ?

[jonesbusy]

Nevermind. I was able to fix the issue by changing the class name for the jest-junit reporter

  "jest-junit": {
    "suiteName": "frontend",
    "classNameTemplate": "{filepath}"
  }

I'm wonder if it was because of spaces inside class name. Changing to the file path creates a package

[uhafner]

"-" is used as fallback if no top-level name is available. Maybe I need to look again at the merging process if there are several files that could not be merged and therefore appear under a new tree root. Maybe I should call it unmapped...