-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage metrics from VectorCAST #153
Conversation
Since I don't have a project with test data (including source code) it would be helpful if you can add screenshots of the changed things in the pull request comment. |
Hi Ulli,
Here’s the screenshots. Please note that unless you have any of the new metrics, the views will not change and non of this will be present:
1. hoverOverDashboard.png – Added new metrics to the hover over on the main Jenkins dashboard
2. jobMainCCTrend.png – Added new metrics to this chart. When any new metrics are present, the chart will change from a filled graph to a line graph
3. covRptOverview.png – Added new metrics to the coverage report. The heat map for new metrics work the same as the original metrics. Chart changes from filled to line as in #2
4. fileMetrics.png – Added new metrics to chart. When new metrics are present, the additional metrics have new columns and column headers
5. tooltip.png – Tooltip code for hover over will display the new metrics as well.
If you want to use the source code, I have it here: https://github.com/TimSVector/PointOfSales_v2.git
|
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/source/CoverageSourcePrinter.java
Fixed
Show fixed
Hide fixed
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/source/CoverageSourcePrinter.java
Fixed
Show fixed
Hide fixed
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/steps/CoverageTableModel.java
Fixed
Show fixed
Hide fixed
Not sure how to solve the Label Checker or PIT errors |
There are no screenshots. Can you edit the description of the PR and add them there? Then everybody can see them in the ChangeLog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to setup the build locally to actually see the changes...
It would be also helpful to have some tests for the source code rendering, so I will not break it in future releases.
You can also add support in the ChecksAPI (CoverageChecksPublisher
) but this is optional.
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/charts/CoverageTrendChart.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/source/CoverageSourcePrinter.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/source/CoverageSourcePrinter.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/source/CoverageSourcePrinter.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/steps/CoverageTableModel.java
Outdated
Show resolved
Hide resolved
...in/resources/io/jenkins/plugins/coverage/metrics/steps/CoverageMetricColumn/help-metric.html
Outdated
Show resolved
Hide resolved
...ain/resources/io/jenkins/plugins/coverage/metrics/steps/CoverageQualityGate/help-metric.html
Show resolved
Hide resolved
.../io/jenkins/plugins/coverage/metrics/steps/coverage-publisher-details.checks-expected-result
Outdated
Show resolved
Hide resolved
|
I think we can ignore the PIT error, it is caused by a PIT upgrade in main. |
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/source/VectorCastSourcePrinter.java
Fixed
Show fixed
Hide fixed
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/source/VectorCastSourcePrinter.java
Fixed
Show fixed
Hide fixed
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/source/VectorCastSourcePrinter.java
Fixed
Show fixed
Hide fixed
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/source/VectorCastSourcePrinter.java
Fixed
Show fixed
Hide fixed
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/source/VectorCastSourcePrinter.java
Fixed
Show fixed
Hide fixed
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/source/VectorCastSourcePrinter.java
Fixed
Show fixed
Hide fixed
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/source/VectorCastSourcePrinter.java
Fixed
Show fixed
Hide fixed
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/source/VectorCastSourcePrinter.java
Fixed
Show fixed
Hide fixed
I added a new test file for statement+branch, statement+MCDC, and statement+branch+function call (includes function coverage) into VectorCastCoverageChecksPublisherTest.java which is derived from CoverageChecksPublisherTest.java. Still getting no Method Coverage |
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/charts/CoverageTrendChart.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/jenkins/plugins/coverage/metrics/charts/CoverageTrendChart.java
Outdated
Show resolved
Hide resolved
plugin/src/main/resources/io/jenkins/plugins/coverage/metrics/steps/Messages.properties
Outdated
Show resolved
Hide resolved
...st/java/io/jenkins/plugins/coverage/metrics/steps/VectorCastCoverageChecksPublisherTest.java
Outdated
Show resolved
Hide resolved
You mean in the overview? The overview shows only value metrics. Details are available as tooltip only. The checks publisher does not show them at all. I can make that overridable if required? |
...n/src/test/java/io/jenkins/plugins/coverage/metrics/steps/VectorCastCoveragePluginITest.java
Fixed
Show resolved
Hide resolved
...n/src/test/java/io/jenkins/plugins/coverage/metrics/steps/VectorCastCoveragePluginITest.java
Fixed
Show resolved
Hide resolved
Method coverage was displaying before we removed it for coverages that didn't contain MCDC/FCC coverage 3 points there the method coverage is missing or incorrect, as MC/DC Pair and/or Function Call coverage should trigger Method Coverage to be displayed
Also, the console log, you can see Function Coverage in the input to the plugin, but no Method coverage in plugin processing: Output from VectorCAST script:
Output from Plugin:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the display of the method coverage in the checks result.
On the tabs this metric is not shown intentionally as it is an aggregated metric and not a value metric. It should be visible in the bar chart though, I need to create a build with this chart...
Where would that image be when I run locally? |
Add a breakpoint after
Click on the link and you will see the Jenkins under test. (Make sure that you enable the breakpoint option |
I see it in debug. I'm going to create a new project in Jenkins and see if that helps. I would like to see Method coverage when there is Function Call and/or MCDC Pairs. |
I created a release of the coverage model now. There is also a bugfix in this release for the merge operations (https://issues.jenkins.io/browse/JENKINS-73352). Would it be ok, if I release this PR right now and we can look afterwards in followup PRs on how to configure other UI elements differently? |
Yes – that would be fine
From: Ullrich Hafner ***@***.***>
Sent: Wednesday, June 26, 2024 5:06 AM
To: jenkinsci/coverage-plugin ***@***.***>
Cc: Schneider, Tim ***@***.***>; Author ***@***.***>
Subject: Re: [jenkinsci/coverage-plugin] Add coverage metrics from VectorCAST (PR #153)
I created a release of the coverage model now. There is also a bugfix in this release for the merge operations (https://issues.jenkins.io/browse/JENKINS-73352).
Would it be ok, if I release this PR right now and we can look afterwards in followup PRs on how to configure other UI elements differently?
—
Reply to this email directly, view it on GitHub<#153 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AENYLQ6GQ2IQHZGDU2RNE33ZJJ77JAVCNFSM6AAAAABH2ZMPFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRGE4TEMZZHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Add in coverage metrics from VectorCAST.