Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include NUnit parser from coverage-model #66

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

jonesbusy
Copy link
Contributor

@jonesbusy jonesbusy commented Jan 24, 2024

Include NUnit parser from coverage-model from jenkinsci/coverage-model#69

Testing done

Automated tests and create one integration test

Submitter checklist

Copy link

  • Surviving mutants in this change: 1
  • Killed mutants in this change: 0
class surviving killed
io.jenkins.plugins.coverage.metrics.steps.CoverageTool$CoverageToolDescriptor 1 0

See https://pitest.org/

@uhafner
Copy link
Member

uhafner commented Jan 24, 2024

See: https://github.com/jenkinsci/coverage-model/releases/tag/v0.39.0

Copy link

  • Surviving mutants in this change: 1
  • Killed mutants in this change: 0
class surviving killed
io.jenkins.plugins.coverage.metrics.steps.CoverageTool$CoverageToolDescriptor 1 0

See https://pitest.org/

@jonesbusy jonesbusy marked this pull request as ready for review January 24, 2024 12:27
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a8fafb0) 81.77% compared to head (306aecd) 81.89%.

Files Patch % Lines
...s/plugins/coverage/metrics/steps/CoverageTool.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #66      +/-   ##
============================================
+ Coverage     81.77%   81.89%   +0.12%     
  Complexity      760      760              
============================================
  Files            47       47              
  Lines          2655     2657       +2     
  Branches        253      253              
============================================
+ Hits           2171     2176       +5     
+ Misses          401      400       -1     
+ Partials         83       81       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner added the feature New features label Jan 24, 2024
@uhafner uhafner merged commit f6f8576 into jenkinsci:main Jan 24, 2024
28 of 30 checks passed
@jonesbusy jonesbusy deleted the feature/nunit-parser branch January 24, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants