Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jenkins-button over yui-button in 'New domain' and 'Update domain' screens #550

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Jul 15, 2024

Small PR to use the jenkins-button class over yui-button in the 'New domain' and 'Update domain' screens.

Before

image image

After

image image

Testing done

  • Button behaves as expected
  • Disables when there isn't a name, enables when there is.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@janfaracik janfaracik requested a review from a team as a code owner July 15, 2024 21:28
@janfaracik janfaracik changed the title Use jenkins-button over yui-button in 'New domain' screen Use jenkins-button over yui-button in 'New domain' and 'Update domain' screens Jul 15, 2024
@mawinter69
Copy link

This is also covered by #533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants