This repository has been archived by the owner on Dec 10, 2023. It is now read-only.
fix: cache objects are now persistent #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akouznetchik
commented
Apr 19, 2023
akouznetchik
commented
- Fixed caching. None of the caches were working. The CacheMap objects were declared, but never initialized. Therefore the cache object passed to setValueToCache() was null and the null check inside the function initialized the cache map that was local scoped, therefore the instance scoped cache objects remained null and were never filled.
DuMaM
reviewed
Apr 19, 2023
| @@ -886,7 +895,7 @@ private <T> void setValueToCache(String key, T value, CacheMap<String, T> cacheO | |||
|
|
|||
| synchronized (this) { | |||
| if (cacheObj == null) { | |||
| cacheObj = new CacheMap<>(cacheSize); | |||
| return; | |||
There was a problem hiding this comment.
this line dont have to be in sync right now but it's ok.
I will move this later on.
DuMaM
approved these changes
Apr 19, 2023
|
I will check this in Friday |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.