Skip to content
This repository has been archived by the owner on Dec 10, 2023. It is now read-only.

deps: upgrade plugin parent POM from 4.57 to 4.61 #174

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

basil
Copy link
Member

@basil basil commented Apr 19, 2023

Adapts to mockito/mockito#2945 by switching our dependency from mockito-inline to mockito-core.

Changes in dependabot PR: #173

@basil basil changed the title Upgrade plugin parent POM from 4.59 to 4.60 Upgrade plugin parent POM from 4.59 to 4.61 Apr 19, 2023
@DuMaM DuMaM changed the title Upgrade plugin parent POM from 4.59 to 4.61 deps: upgrade plugin parent POM from 4.57 to 4.61 Apr 19, 2023
@DuMaM DuMaM added the dependencies Dependency updates label Apr 19, 2023
@DuMaM DuMaM merged commit 8c7343b into jenkinsci:master Apr 19, 2023
@DuMaM
Copy link
Contributor

DuMaM commented Apr 21, 2023

@basil i dont know why but after this change i'm unable to release this plugin

@DuMaM
Copy link
Contributor

DuMaM commented Apr 21, 2023

[INFO] Checking in modified POMs...
[INFO] Executing: /bin/sh -c cd '/Users/nowakb/Work/jenkins/crowd2-plugin' && 'git' 'add' '--' 'pom.xml'
[INFO] Working directory: /Users/nowakb/Work/jenkins/crowd2-plugin
[INFO] Executing: /bin/sh -c cd '/Users/nowakb/Work/jenkins/crowd2-plugin' && 'git' 'rev-parse' '--show-prefix'
[INFO] Working directory: /Users/nowakb/Work/jenkins/crowd2-plugin
[INFO] Executing: /bin/sh -c cd '/Users/nowakb/Work/jenkins/crowd2-plugin' && 'git' 'status' '--porcelain' '.'
[INFO] Working directory: /Users/nowakb/Work/jenkins/crowd2-plugin
[WARNING] Ignoring unrecognized line: ?? pom.xml.releaseBackup
[WARNING] Ignoring unrecognized line: ?? release.properties
[INFO] Executing: /bin/sh -c cd '/Users/nowakb/Work/jenkins/crowd2-plugin' && 'git' 'commit' '--verbose' '-F' '/var/folders/17/ntnj42vj25763wvvvmlgzs3m4yq_p4/T/maven-scm-1097695392.commit'
[INFO] Working directory: /Users/nowakb/Work/jenkins/crowd2-plugin
[INFO] Executing: /bin/sh -c cd '/Users/nowakb/Work/jenkins/crowd2-plugin' && 'git' 'symbolic-ref' 'HEAD'
[INFO] Working directory: /Users/nowakb/Work/jenkins/crowd2-plugin
[INFO] Executing: /bin/sh -c cd '/Users/nowakb/Work/jenkins/crowd2-plugin' && 'git' 'push' 'git@github.com/jenkinsci/crowd2-plugin.git' 'refs/heads/master:refs/heads/master'
[INFO] Working directory: /Users/nowakb/Work/jenkins/crowd2-plugin
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  27.481 s
[INFO] Finished at: 2023-04-21T23:48:43+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:3.0.0:prepare (default-cli) on project crowd2: Unable to commit files
[ERROR] Provider message:
[ERROR] The git-push command failed.
[ERROR] Command output:
[ERROR] fatal:********@github.com/jenkinsci/crowd2-plugin.git' does not appear to be a git repository
[ERROR] fatal: Could not read from remote repository.
[ERROR] 
[ERROR] Please make sure you have the correct access rights
[ERROR] and the repository exists.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException```

@basil
Copy link
Member Author

basil commented Apr 21, 2023

developerConnection looks wrong:

diff --git a/pom.xml b/pom.xml
index 8aa199e..1a12624 100644
--- a/pom.xml
+++ b/pom.xml
@@ -65,7 +65,7 @@
 
     <scm>
         <connection>scm:git:https://github.com/${gitHubRepo}.git</connection>
-        <developerConnection>scm:git:git@github.com/${gitHubRepo}.git</developerConnection>
+        <developerConnection>scm:git:git@github.com:${gitHubRepo}.git</developerConnection>
         <url>https://github.com/${gitHubRepo}</url>
         <tag>${scmTag}</tag>
     </scm>

@DuMaM
Copy link
Contributor

DuMaM commented Apr 21, 2023

Oh... Yeah. Its missing :

@DuMaM
Copy link
Contributor

DuMaM commented Apr 21, 2023

thanks man

@basil basil deleted the mockito branch April 21, 2023 23:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants