Skip to content
This repository has been archived by the owner on Dec 10, 2023. It is now read-only.

[JENKINS-68459] Prepare Crowd 2 Integration for removal of JAXB and Java 11 requirement #72

Merged
merged 2 commits into from
May 10, 2022

Conversation

basil
Copy link
Member

@basil basil commented May 9, 2022

See JENKINS-68459. This plugin bundles com.atlassian.crowd:crowd-integration-client-rest:jar:3.7.1, which consumes JAXB. But when running on Java 9+, JAXB is not included on the classpath by default. The only way for a plugin to have access to JAXB when running on Jenkins 2.164 or later is to declare a plugin-to-plugin dependency on JAXB API plugin (recommended) or to embed JAXB into its .jpi file. This PR does the former to ensure that Crowd 2 Integration always has access to JAXB on its classpath. CC @DuMaM

@DuMaM
Copy link
Contributor

DuMaM commented May 9, 2022

So basically it's the same as #71.
I was going to test it tomorrow, because it's 2:00 am in my timezone.
You can test it by running ./start.sh 11

@basil
Copy link
Member Author

basil commented May 10, 2022

I wasn't aware of that other PR, but yes this is solving the same problem. Please test this yourself as I have no time to test individual plugins. I am just a core maintainer (I don't use this plugin) and I am going around filing dozens of PRs across the ecosystem to do this monotonous task.

@DuMaM
Copy link
Contributor

DuMaM commented May 10, 2022

I just did it and it partially solved my problem. Now Jenkins is lunching again with this 😄
I need to fix one more before i do release.

@DuMaM
Copy link
Contributor

DuMaM commented May 10, 2022

@basil @ikedam Thanks guys you solved one issue I was facing for quite long time.
Now only this one left and I'm releasing plugin https://issues.jenkins.io/browse/JENKINS-68479

@DuMaM DuMaM merged commit 82d51b2 into jenkinsci:master May 10, 2022
@DuMaM
Copy link
Contributor

DuMaM commented May 10, 2022

Damt. It fixed all problems 😵‍💫 (apart this telemetry one)
Somehow my email fetching fixes from Java 8 wasn't working on Java 11.
Now everything is as it's supposed to be ❤️
One more time great thanks to you guys.

I will release plugin tomorrow

@basil basil deleted the JENKINS-68459 branch May 10, 2022 01:21
@basil
Copy link
Member Author

basil commented May 10, 2022

I don't think JENKINS-68479 is a real issue. The missing class telemetry was ripped out months ago in jenkinsci/jenkins#5666. The actual warning you're seeing is just a warning, and it shouldn't matter because that class is just an annotation that has no impact at runtime. We actually switched from JSR 305 annotations to SpotBugs annotations a while back, but it seems one of your dependencies is still using JSR 305 (not that it matters).

@ikedam
Copy link
Member

ikedam commented May 10, 2022

The missing class telemetry was ripped out months ago in jenkinsci/jenkins#5666

Note: the merge commit is jenkinsci/jenkins@c9eaf34 and available since jenkins-2.308/jenkins- 2.319.1 .
(this might be helpful to test the behavior)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants