-
Notifications
You must be signed in to change notification settings - Fork 57
[JENKINS-68459] Prepare Crowd 2 Integration for removal of JAXB and Java 11 requirement #72
Conversation
So basically it's the same as #71. |
I wasn't aware of that other PR, but yes this is solving the same problem. Please test this yourself as I have no time to test individual plugins. I am just a core maintainer (I don't use this plugin) and I am going around filing dozens of PRs across the ecosystem to do this monotonous task. |
I just did it and it partially solved my problem. Now Jenkins is lunching again with this 😄 |
@basil @ikedam Thanks guys you solved one issue I was facing for quite long time. |
Damt. It fixed all problems 😵💫 (apart this telemetry one) I will release plugin tomorrow |
I don't think JENKINS-68479 is a real issue. The missing class telemetry was ripped out months ago in jenkinsci/jenkins#5666. The actual warning you're seeing is just a warning, and it shouldn't matter because that class is just an annotation that has no impact at runtime. We actually switched from JSR 305 annotations to SpotBugs annotations a while back, but it seems one of your dependencies is still using JSR 305 (not that it matters). |
Note: the merge commit is jenkinsci/jenkins@c9eaf34 and available since jenkins-2.308/jenkins- 2.319.1 . |
See JENKINS-68459. This plugin bundles
com.atlassian.crowd:crowd-integration-client-rest:jar:3.7.1
, which consumes JAXB. But when running on Java 9+, JAXB is not included on the classpath by default. The only way for a plugin to have access to JAXB when running on Jenkins 2.164 or later is to declare a plugin-to-plugin dependency on JAXB API plugin (recommended) or to embed JAXB into its.jpi
file. This PR does the former to ensure that Crowd 2 Integration always has access to JAXB on its classpath. CC @DuMaM