Set user-select: none in SVG for better UX #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strangelookingnerd
force-pushed
the
feature/set_user-select_none_on_svg
branch
from
780d517 to
fcf4a39
Compare
strangelookingnerd
force-pushed
the
feature/set_user-select_none_on_svg
branch
from
fcf4a39 to
34f6b02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the emojis are actually text in a SVG they remain "select-able" which is undesirable from a UX perspective since they are supposed to be used as icons.
Testing done
Manually tested.
Submitter checklist