Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on config-file-provider explicitly (#280) #282

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Depend on config-file-provider explicitly (#280) #282

merged 2 commits into from
Jan 8, 2024

Conversation

strangelookingnerd
Copy link
Contributor

See #280

Testing done

None.

Submitter checklist
Preview Give feedback

@strangelookingnerd strangelookingnerd linked an issue Jan 8, 2024 that may be closed by this pull request
custom-folder-icon 2.11 fails tests in plugin bill of materials #280
Closed
@strangelookingnerd strangelookingnerd enabled auto-merge (squash) January 8, 2024 12:37
MarkEWaite
MarkEWaite reviewed Jan 8, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@strangelookingnerd @MarkEWaite
Use version provided by bom
3b1f550 
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
@strangelookingnerd strangelookingnerd enabled auto-merge (squash) January 8, 2024 12:45
MarkEWaite
MarkEWaite approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@MarkEWaite
Copy link
Contributor

Could be labeled test so that it will be described in the changelog as a test change. Thanks again.

@strangelookingnerd strangelookingnerd self-assigned this Jan 8, 2024
@strangelookingnerd strangelookingnerd merged commit b3f7636 into main Jan 8, 2024
15 of 16 checks passed
@strangelookingnerd strangelookingnerd deleted the fix-tests-failing-in-plugin-bill-of-materials branch January 8, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees

@strangelookingnerd strangelookingnerd

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

custom-folder-icon 2.11 fails tests in plugin bill of materials
2 participants
@strangelookingnerd @MarkEWaite