Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new set of OpenSource icon using oss-symbols-api-plugin #373

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Add new set of OpenSource icon using oss-symbols-api-plugin #373

merged 3 commits into from
Aug 30, 2024

Conversation

jonesbusy
Copy link
Contributor

Fix #372

Testing done

Automated tests and interactive. See screenshots

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy requested a review from a team as a code owner August 30, 2024 05:01
strangelookingnerd
strangelookingnerd requested changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@strangelookingnerd strangelookingnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far, I added some minor suggestions.

README.adoc Outdated Show resolved Hide resolved
src/main/java/jenkins/plugins/foldericon/OpenSourceFolderIcon.java Outdated Show resolved Hide resolved
src/main/resources/jenkins/plugins/foldericon/OpenSourceFolderIcon/config.jelly Outdated Show resolved Hide resolved
src/main/resources/jenkins/plugins/foldericon/OpenSourceFolderIcon/config.properties Outdated Show resolved Hide resolved
src/main/resources/jenkins/plugins/foldericon/OpenSourceFolderIcon/help-preview.html Outdated Show resolved Hide resolved
src/main/webapp/css/oss.css Outdated Show resolved Hide resolved
src/main/webapp/js/oss-config.js Outdated Show resolved Hide resolved
@strangelookingnerd strangelookingnerd added the enhancement New feature or request label Aug 30, 2024
@strangelookingnerd strangelookingnerd self-assigned this Aug 30, 2024
@jonesbusy
Copy link
Contributor Author

Fixed the comments

@strangelookingnerd strangelookingnerd merged commit ce5c13c into jenkinsci:main Aug 30, 2024
19 checks passed
@jonesbusy jonesbusy deleted the feature/oss-icons branch August 30, 2024 10:07
@strangelookingnerd
Copy link
Contributor

Thanks for the contribution! I'll push a release later today.

@jonesbusy
Copy link
Contributor Author

Thanks!

@jonesbusy
Copy link
Contributor Author

Hi,

Are you planning a release soon ? WIth the upcoming 2.462.2 tomorrow I would like if possible to update also this plugin to allow OSS icon

Thanks!

@strangelookingnerd
Copy link
Contributor

I wanted to finish up #376 before releasing. Should be ready later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strangelookingnerd strangelookingnerd strangelookingnerd approved these changes

Assignees

@strangelookingnerd strangelookingnerd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Future new icon set integration
2 participants
@jonesbusy @strangelookingnerd