Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Cards' docs #347

Merged
merged 24 commits into from
Nov 11, 2024
Merged

Add 'Cards' docs #347

merged 24 commits into from
Nov 11, 2024

Conversation

janfaracik
Copy link
Contributor

Adds some guidance for using cards in Jenkins.

cards

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@janfaracik janfaracik requested a review from a team as a code owner November 11, 2024 15:32
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not ran locally)

@janfaracik janfaracik merged commit 301efa3 into jenkinsci:master Nov 11, 2024
16 checks passed
@janfaracik janfaracik deleted the add-cards branch November 11, 2024 15:54
@uhafner
Copy link
Member

uhafner commented Nov 13, 2024

Thanks for starting this topic! For me as a plugin author a lot of things are missing, maybe it makes sense to add "in progress" message for this topic.

  • Where should I use cards? (On which pages?)
  • How can I create cards?
  • How do I set the size (or shouldn't they use a predefined grid?)
  • Does the expand work out of the box or do I need to program that on my own?
  • Do the cards automatically adapt to the screen size? (So will have something in the style of https://muuri.dev/?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants