Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test that would be stuck in a loop #62

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

froque
Copy link
Member

@froque froque commented Jan 28, 2023

If this unit test would start with seconds between 55 and 59 would never exit the loop.
Changed to start the work in a thread and wait 1 minute and check that no new work was performed.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

If this unit test would start with seconds between 55 and 59 would never
exit the loop.
Changed to start the work in a thread and wait 1 minute and check that no
new work was performed.
@froque froque merged commit 0f6032d into master Jan 28, 2023
@froque froque deleted the fix_testTaskIsScheduledOnlyOneTimesPerMinute branch January 28, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant