Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL on images #63

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Fix URL on images #63

merged 1 commit into from
Jan 28, 2023

Conversation

froque
Copy link
Member

@froque froque commented Jan 28, 2023

When display a project,, icons before Job, All bilds, Locked builds, All workspaces, Slave workspaces, Non-slave workspaces have a broken link.

The root URL was missing, add ${resURL} as prefix in the attribute src, for node img.

Fixes https://issues.jenkins.io/browse/JENKINS-30830 wrong path in html output to directory16.png

This was already done on #34 but was archived in branch https://github.com/jenkinsci/disk-usage-plugin/tree/master-archive and never released.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

When display a project,, icons before Job, All bilds, Locked builds, All
workspaces, Slave workspaces, Non-slave workspaces have a broken link.

The root URL was missing, add ${resURL} as prefix in the attribute src,
for node img.
@froque froque merged commit d54dff5 into master Jan 28, 2023
@froque froque deleted the fix_JENKINS-30830_url_images branch January 28, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants