Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate jenkins-slave launcher in favor of one using -jnlpUrl #693

Closed
jglick opened this issue Apr 22, 2019 · 3 comments
Closed

Deprecate jenkins-slave launcher in favor of one using -jnlpUrl #693

jglick opened this issue Apr 22, 2019 · 3 comments

Comments

@jglick
Copy link
Member

jglick commented Apr 22, 2019

The normal way to launch inbound agents, as advertised on the agent page, is

java -jar agent.jar -jnlpUrl http://jenkins/computer/myagent/slave-agent.jnlp -secret XXX

This goes through hudson.remoting.Launcher, which downloads the result of SlaveComputer/slave-agent.jnlp.jelly. That exposes JNLPLauncher.tunnel and .workDirSettings, does some other preparation, and finally delegates to the lower-level hudson.remoting.jnlp.Main.

For some reason I cannot follow, jenkins-slave in this image runs hudson.remoting.jnlp.Main directly, ignoring any tunnel and/or workDirSettings configured in the launcher.

Not sure if an existing entrypoint be deprecated. Perhaps this whole image should be deprecated in favor of one using the more convenient launcher class.

@jglick
Copy link
Member Author

jglick commented Dec 6, 2019

See also kubernetes plugin setup.

@jglick
Copy link
Member Author

jglick commented Dec 6, 2019

On the other hand this would not be compatible with direct connection mode (-direct, -instanceIdentity, -protocols) as in jenkinsci/docker-inbound-agent#118, the whole point of which is to avoid making an HTTP connection.

@jglick
Copy link
Member Author

jglick commented Jul 17, 2020

No longer intending to do this.

@jglick jglick closed this as completed Jul 17, 2020
@lemeurherve lemeurherve transferred this issue from jenkinsci/docker-inbound-agent Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants