-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate jenkins-slave launcher in favor of one using -jnlpUrl #693
Labels
Comments
This was referenced Apr 22, 2019
See also |
On the other hand this would not be compatible with direct connection mode ( |
No longer intending to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The normal way to launch inbound agents, as advertised on the agent page, is
This goes through
hudson.remoting.Launcher
, which downloads the result ofSlaveComputer/slave-agent.jnlp.jelly
. That exposesJNLPLauncher.tunnel
and.workDirSettings
, does some other preparation, and finally delegates to the lower-levelhudson.remoting.jnlp.Main
.For some reason I cannot follow,
jenkins-slave
in this image runshudson.remoting.jnlp.Main
directly, ignoring anytunnel
and/orworkDirSettings
configured in the launcher.Not sure if an existing entrypoint be deprecated. Perhaps this whole image should be deprecated in favor of one using the more convenient launcher class.
The text was updated successfully, but these errors were encountered: