feat(platforms): Adds ppc64le and s390x archs for JDK21. #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
reviewed
Sep 13, 2023
Comment on lines
+29
to
+30
| # It is acceptable to have a larger image in arm/v7 (arm 32 bits) environment. | ||
| # Because jlink fails with the error "jmods: Value too large for defined data type" error. |
There was a problem hiding this comment.
did you test and see if this is still needed?
There was a problem hiding this comment.
Yes, I tested that this morning, and it's still the case.
Thanks.
There was a problem hiding this comment.
Hi, this error you were having with jlink is caused by running a 32-bit arm qemu emulator on a 64-bit host. When jlink tries to open a large (>2GB) file mmap fails.
There was a problem hiding this comment.
Thank you Kenneth. 🙏
It looks like this bug will never be fixed. 🤷
timja
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing with @ksalerno99 yesterday during the Platform SIG meeting, I considered that adding support for a few platforms for JDK21 would be beneficial.
I then propose to add
"linux/ppc64le","linux/armv/v7"and"linux/s390x"as new target platforms for our JDK21 preview images.Testing done
docker buildx bake --file docker-bake.hcl debian_jdk21Submitter checklist
Link to relevant issues in GitHub or JiraLink to relevant pull requests, esp. upstream and downstream changes