fix(windows) bump git-lfs to 3.4.0 and fix its installation
#503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemeurherve
changed the title
PATH before installing git-lfs version 3.4.0git-lfs version 3.4.0 installation
lemeurherve
changed the title
git-lfs version 3.4.0 installationgit-lfs version 3.4.0 installation on Nanoserver images
Vlatombe
reviewed
Sep 13, 2023
Vlatombe
reviewed
Sep 13, 2023
lemeurherve
commented
Sep 13, 2023
lemeurherve
changed the title
git-lfs version 3.4.0 installation on Nanoserver imagesgit-lfs version 3.4.0 installation on Nanoserver images
|
Updatecli is failing as expected since the test target doesn't exist on the master branch yet. |
lemeurherve
changed the title
git-lfs version 3.4.0 installation on Nanoserver imagesgit-lfs to 3.4.0 and fix its installation on Nanoserver images
|
Back to draft, the windowsservercore git-lfs install doesn't fail but the test show that it's not installed. I'll do the same change on windowsservercore image. |
lemeurherve
changed the title
git-lfs to 3.4.0 and fix its installation on Nanoserver imagesgit-lfs to 3.4.0 and fix its installation on Windows images
|
Same change applied to windowsservercore image. Out of curiosity I opened #504 to check if git-lfs 3.1.4 was indeed installed in Windows images, it was, PR closed in favor of this one. PR ready for review. |
dduportal
changed the title
git-lfs to 3.4.0 and fix its installation on Windows imagesgit-lfs to 3.4.0 and fix its installation
|
Merging as the updatecli checks are failing until merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
git: 'lfs' is not a git command.error noticed in #502 (comment) when using the version 3.4.0 of git-lfs by adding git to thePATHearlier then using git-lfs.exe installer instead ofgit.exe lfs install.It also adds a test ensuring git-lfs (and thus git) is correctly installed.
Supersedes and closes #502
Testing done
https://ci.jenkins.io/job/Packaging/job/docker-agent/job/PR-503/11/
Submitter checklist