Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(updatecli): correct type of conditions for jdk21 manifest #556

Merged
merged 5 commits into from
Oct 30, 2023
Merged

chore(updatecli): correct type of conditions for jdk21 manifest #556

merged 5 commits into from
Oct 30, 2023

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Oct 29, 2023 •
edited
Loading

This PR replaces the type of conditions for the jdk21 updatecli manifest.
Unlike the jdk21-preview manifest this one is issued from, we have to check for the existence of docker images, not GitHub releases.

Fixup of #536

Fixes #555 and closes #552 and closes #560 (GA docker images not yet available)

Testing done

Submitter checklist
Preview Give feedback

@lemeurherve lemeurherve requested a review from a team as a code owner October 29, 2023 14:10
@lemeurherve lemeurherve linked an issue Oct 29, 2023 that may be closed by this pull request
The jdk21 updatecli manifest is missing conditions on docker images #555
Closed
@lemeurherve lemeurherve marked this pull request as draft October 29, 2023 22:53
dduportal
dduportal requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updatecli diff command fails the JDK21 manifest with the following error:

ERROR: failed loading pipeline(s)
	* "updatecli/updatecli.d/jdk21.yaml" - yaml: line 46: mapping values are not allowed in this context

but I'm not sure why?

@lemeurherve

This comment was marked as outdated.

Sign in to view
@lemeurherve lemeurherve marked this pull request as ready for review October 30, 2023 09:37
@lemeurherve lemeurherve mentioned this pull request Oct 30, 2023
Merged
@lemeurherve lemeurherve requested a review from dduportal October 30, 2023 11:05
@dduportal dduportal changed the title fix(updatecli): correct type of conditions for jdk21 manifest chore(updatecli): correct type of conditions for jdk21 manifest Oct 30, 2023
@dduportal dduportal added chore and removed bug labels Oct 30, 2023
dduportal
dduportal approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Changed the title and labels (as this PR does not change the produced image so it can't be a "fix").

THe checks show the expected result: skipping JDK21 pipeline due to unpublished images

@dduportal dduportal merged commit 16f8c37 into jenkinsci:master Oct 30, 2023
@lemeurherve lemeurherve deleted the issue555-add-missing-conditions-to-jdk21-updatecli-manifest branch October 30, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
chore jdk21 updatecli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The jdk21 updatecli manifest is missing conditions on docker images
2 participants
@lemeurherve @dduportal