Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jdk21) Use Liberica official build for linux/arm/v7 #778

Closed
wants to merge 9 commits into from

Conversation

gounthar
Copy link
Contributor

@gounthar gounthar commented Mar 19, 2024

As discussed in #772, the community has decided to discontinue supplying arm32 docker images since Temurin does not plan to release them.
Through this PR, I aim to present an alternative by using Liberica JDK binaries.
I'm not suggesting we should make this change; I'm merely proposing that we could, considering the minor changes required in our repository.

However, it's essential to note that while the changes in our repository may be minor, the impact on end-users could be significant.
Should we abandon arm32 images altogether, or should we consider switching to another JDK vendor for just this platform?
I don't have a definitive answer.

Please view this PR as a proof of concept rather than a desperate plea to reinstate arm32 support.
If the community were to accept this proposal, I would be willing to maintain it.

While I still hold hope that Temurin will eventually resume regular arm32 builds for JDK21+, it's essential to acknowledge the constraints faced by open-source projects, including limited time, hardware, and resources.

I realize that I should have split the PR into two parts, as the updatecli manifest should fail due to a missing variable in the master branch.

Thank you for your time.

Testing done

make ARCH=arm/v7 build-agent_debian_jdk21_liberica
updatecli diff --debug --config ./updatecli/updatecli.d/jdk21-arm32.yaml --values ./updatecli/values.github-action.yaml

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant