feat(Windows): switch from temurin base images to temurin installer #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemeurherve
force-pushed
the
helpdesk4029-switch-off-from-eclipse-temurin-base-images-windows
branch
from
baab2b7 to
c8be815
Compare
lemeurherve
force-pushed
the
helpdesk4029-switch-off-from-eclipse-temurin-base-images-windows
branch
from
c8be815 to
62ac3eb
Compare
Merged
5 tasks
dduportal
added a commit
to dduportal/docker-inbound-agents
that referenced
this pull request
Apr 24, 2024
It introduces the following changes: - Faster build due to less layers to pull (ref. jenkinsci/docker-agent#787) - Retrieving the `netapi32` DLL and `whoami.exe`` from the Python parent image instead of Temurin image - Moving `ARG JAVA_VERSION` into the last stage's scope - Pin JDK21 version to 21+35 to ensure a valid installer is retrieved Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
added a commit
to dduportal/docker-inbound-agents
that referenced
this pull request
Apr 24, 2024
It introduces the following changes: - Faster build due to less layers to pull (ref. jenkinsci/docker-agent#787) - Retrieving the `netapi32` DLL and `whoami.exe`` from the Python parent image instead of Temurin image - Moving `ARG JAVA_VERSION` into the last stage's scope - Pin JDK21 version to 21+35 to ensure a valid installer is retrieved Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
added a commit
to dduportal/docker-inbound-agents
that referenced
this pull request
Apr 24, 2024
It introduces the following changes: - Faster build due to less layers to pull (ref. jenkinsci/docker-agent#787) - Retrieving the `netapi32` DLL and `whoami.exe`` from the Python parent image instead of Temurin image - Moving `ARG JAVA_VERSION` into the last stage's scope - Pin JDK21 version to 21+35 to ensure a valid installer is retrieved Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
added a commit
to dduportal/docker-inbound-agents
that referenced
this pull request
Apr 24, 2024
It introduces the following changes: - Faster build due to less layers to pull (ref. jenkinsci/docker-agent#787) - Retrieving the `netapi32` DLL and `whoami.exe`` from the Python parent image instead of Temurin image - Moving `ARG JAVA_VERSION` into the last stage's scope - Pin JDK21 version to 21+35 to ensure a valid installer is retrieved Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
added a commit
to jenkins-infra/docker-inbound-agents
that referenced
this pull request
Apr 24, 2024
It introduces the following changes: - Faster build due to less layers to pull (ref. jenkinsci/docker-agent#787) - Retrieving the `netapi32` DLL and `whoami.exe`` from the Python parent image instead of Temurin image - Moving `ARG JAVA_VERSION` into the last stage's scope - Pin JDK21 version to 21+35 to ensure a valid installer is retrieved Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…in-base-images-windows
This was referenced May 4, 2024
lemeurherve
deleted the
helpdesk4029-switch-off-from-eclipse-temurin-base-images-windows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches from temurin base images to the temurin installer for the Windows images.
Benefits:
Notes:
jdk-corebase image for the nanoserver image: we can't use a nanoserver one as we need to retrieve some files from a Windows Server Core anywaydocker-agent/windows/nanoserver/Dockerfile
Lines 40 to 41 in e2560a9
The alternative would be to retrieve the jdk from an existing Windows Server Core agent image and thus having to wait for it to be available first as trade-off.
FTR, that's how Adoptium is making their own nanoserver image: https://github.com/adoptium/containers/blob/df93f85c97eff616bf43de2c6ff7661d4174f833/21/jdk/windows/nanoserver-1809/Dockerfile#L34
Split of:
The updatecli manifests will be updated at once after switching off Windows and Linux images.
Ref:
jenkins/*container images on DockerHub errors withHTTP/429jenkins-infra/helpdesk#4029 (comment)Testing done
Local builds + CI
Submitter checklist