chore: add show-% Makefile target and use jdks_to_build in rhel_ubi9 bake target
#945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 2, 2025
lemeurherveCB
commented
Mar 2, 2025
| @@ -280,7 +280,7 @@ target "debian" { | |||
| target "rhel_ubi9" { | |||
| matrix = { | |||
| type = agent_types_to_build | |||
| jdk = [17, 21] | |||
There was a problem hiding this comment.
Previously (and rightfully at that time) hardcoded to [17, 21] instead of jdk_to_build in #866 as there was no jdk11 image for rhel-ubi9, only for rhel-ubi8.
lemeurherveCB
changed the title
show-% Makefile target and use jdks_to_build in rhel_ubi9 targetshow-% Makefile target and use jdks_to_build in rhel_ubi9 bake target
timja
approved these changes
Mar 2, 2025
dduportal
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show-%Makefile target: allow debugging Windows targets on a Linux or MacOS machine.jdks_to_buildinrhel_ubi9bake target: follow-up of Remove Java 11 support #890Extracted from:
Testing done
Tested like #944 + CI
Submitter checklist