[JENKINS-57420] - Use f:secretTextarea for client private key #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the form UI for client keys to use the newly introduced f:secretTextarea Jelly tag from Jenkins 2.171. Now the client key can be more securely entered and updated. Signed-off-by: Matt Sicker <boards@gmail.com>
|
@jglick I tested this with docker-workflow-plugin, and it still compiles fine. I can make a test PR with the incremental release when it's uploaded. |
jglick
approved these changes
Apr 22, 2019
jeffret-b
approved these changes
Apr 22, 2019
|
I will review it and release tomorrow if it is feasible |
oleg-nenashev
previously requested changes
Apr 30, 2019
There was a problem hiding this comment.
Sorry @jvz , it seems I see a Binary compatibility issue in the current implementation. Needs to be investigated before merging
src/main/java/org/jenkinsci/plugins/docker/commons/credentials/DockerServerCredentials.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matt Sicker <boards@gmail.com>
Signed-off-by: Matt Sicker <boards@gmail.com>
|
@oleg-nenashev I've addressed the ABI compatibility issue. |
src/main/java/org/jenkinsci/plugins/docker/commons/credentials/DockerServerCredentials.java
Show resolved
Hide resolved
jglick
approved these changes
May 1, 2019
src/main/java/org/jenkinsci/plugins/docker/commons/credentials/DockerServerCredentials.java
Show resolved
Hide resolved
Co-Authored-By: jvz <boards@gmail.com>
oleg-nenashev
approved these changes
May 1, 2019
|
@oleg-nenashev can this be merged now? |
Wadeck
approved these changes
May 9, 2019
Signed-off-by: Matt Sicker <boards@gmail.com>
|
@oleg-nenashev I've reverted the version upgrade and am now using the temporary library instead. |
oleg-nenashev
approved these changes
May 13, 2019
oleg-nenashev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the form UI for client keys to use the newly introduced
f:secretTextarea Jelly tag from Jenkins 2.171. Now the client key can
be more securely entered and updated.
Recreated based on #75.
@jglick @jeffret-b @Wadeck @dwnusbaum