Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

chore(Release Drafter) cleanup and allow manual execution #284

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Sep 29, 2022

This PR cleans up the release drafter workflow:

  • Remove a duplicated workflow
  • Switch to a reusable one
  • Allow manual excution of release-drafter by add the workflow_dispatch trigger (use case: regenerate a draft changelog after adding missing labels on PRs already merged)
  • Use a fixed version name (as releases of this images follow concatenation of the remoting version with a suffix build number)

@dduportal dduportal changed the title Delete changelog.yml chore(Release Drafter) cleanup and allow manual execution Sep 29, 2022
@dduportal dduportal marked this pull request as ready for review September 29, 2022 13:38
@dduportal dduportal requested a review from a team as a code owner September 29, 2022 13:38
@dduportal dduportal marked this pull request as draft September 29, 2022 13:42
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a reusable one here that could be used:
https://github.com/jenkinsci/.github/blob/master/.github/workflows/release-drafter.yml

but if it's fixed to v5 here it should be fine to keep this

@dduportal
Copy link
Contributor Author

There's also a reusable one here that could be used: https://github.com/jenkinsci/.github/blob/master/.github/workflows/release-drafter.yml

but if it's fixed to v5 here it should be fine to keep this

Oh, I did not know. Let me switch to the reusable one to avoid spreading configs.

Side note: shall we force the release draft name to something static such as next now that we are using the CD default version scheme + it's the concatenation of the remoting version with a suffix (build number)?

@timja
Copy link
Member

timja commented Sep 29, 2022

Side note: shall we force the release draft name to something static such as next now that we are using the CD default version scheme + it's the concatenation of the remoting version with a suffix (build number)?

no opinion on that, either is fine

@dduportal dduportal marked this pull request as ready for review September 29, 2022 14:18
@dduportal dduportal merged commit 6ac8068 into master Sep 29, 2022
@dduportal dduportal deleted the chore/cleanup-gh-workflow branch September 29, 2022 14:51
lemeurherve pushed a commit to lemeurherve/jenkinsci-docker-inbound-agent that referenced this pull request Nov 19, 2023
* General Windows Updates
  - Remove java 8 images
  - Make java 11 images default
  - Change to pester 5.3
  - Add ltsc2022 images for nano and windowsservercore
* Remove Java 8 from Linux build
* 2022 not buildable with 2019
* Remove references to jdk8 for Linux images

Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants