This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
fix: keep the parent image label with the proper remoting version (fixes hadolint violations) #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
approved these changes
Nov 23, 2022
|
Putting back as "Draft": the Windows SHELL should be the cmd.exe, not powershell.exe. When I tested locally, I tried the wrong Dockerfiles. |
…xes hadolint violations) Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
chore/hadolint
branch
from
d3f12a8
to
c6117a4
Compare
dduportal
changed the title
|
Rebased against the (simplified) master branch, simplified the change and advertise as a bugfix instead of a chore |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-describing title :)
1 commit per rule.