This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
[Windows] Allow JENKINS_URL to not be set when JENKINS_DIRECT_CONNECTION is set #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #358 by only requiring `JENKINS_URL` have a value when `JENKINS_DIRECT_CONNECTION` is not set as well.
timja
approved these changes
Jun 28, 2023
lemeurherve
pushed a commit
to lemeurherve/jenkinsci-docker-inbound-agent
that referenced
this pull request
Jul 8, 2023
lemeurherve
pushed a commit
to lemeurherve/jenkinsci-docker-inbound-agent
that referenced
this pull request
Jul 8, 2023
lemeurherve
pushed a commit
to lemeurherve/jenkinsci-docker-inbound-agent
that referenced
this pull request
Nov 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes jenkinsci/docker-agent#590 by only requiring
JENKINS_URLhave a value whenJENKINS_DIRECT_CONNECTIONis not set as well.Testing done
Made the change on my own Jenkins and verified it worked when
JENKINS_URLis not set butJENKINS_DIRECT_CONNECTIONis.Submitter checklist