Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat(jdk): Add preview images for jdk21 #397

Merged
merged 6 commits into from
Sep 8, 2023
Merged

feat(jdk): Add preview images for jdk21 #397

merged 6 commits into from
Sep 8, 2023

Conversation

gounthar
Copy link
Contributor

@gounthar gounthar commented Sep 8, 2023 •
edited
Loading

Fixes jenkinsci/docker-agent#587 .
This is something that was discussed in jenkinsci/docker-agent#587 .
This work follows the issue and PR brought by @nbr23.
I had to modify TEST_VERSION="3148.v532a_7e715ee3" in tests.bats because there is no 3131xxx version for JDK21.
The first JDK21-compatible version is 3148.v532a_7e715ee3.

Testing done

 make build-debian_jdk21
 make build-alpine_jdk21

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@gounthar
feat(jdk): Adds JDK21 Alpine image
f937187
@gounthar
feat(jdk): Adds JDK21 Alpine image
d0eb8e8
@gounthar
feat(jdk): Adds JDK21 Debian image
393d20f
@gounthar
fix(docker): Not necessary but consistent.
88fe699
@gounthar
fix(tests): Image not found.
4373173 
ERROR: docker.io/jenkins/agent:3131.vf2b_b_798b_ce99-4-alpine-jdk21-preview: not found
@gounthar
fix(tests): Image not found.
dcde80d 
ERROR: docker.io/jenkins/agent:3131.vf2b_b_798b_ce99-4-alpine-jdk21-preview: not found
@gounthar gounthar marked this pull request as ready for review September 8, 2023 14:11
@gounthar gounthar requested a review from a team as a code owner September 8, 2023 14:11
timja
timja approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one concern on alpine is we don't know if they will actually offer it at GA but i guess we can remove it when we swap to non preview tags if so

@dduportal dduportal merged commit 09618e6 into jenkinsci:master Sep 8, 2023
5 checks passed
@gounthar gounthar deleted the jdk21-preview branch September 8, 2023 15:38
@dduportal dduportal mentioned this pull request Oct 22, 2023
Merged
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
@gounthar @lemeurherve
[PATCH] Merge pull request jenkinsci/docker-inbound-agent#397 from go…
cbdfbcd 
…unthar/jdk21-preview

feat(jdk): Add preview images for jdk21
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
@gounthar @lemeurherve
[PATCH] Merge pull request jenkinsci/docker-inbound-agent#397 from go…
78e6fb8 
…unthar/jdk21-preview

feat(jdk): Add preview images for jdk21
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
@gounthar @lemeurherve
[PATCH] Merge pull request jenkinsci/docker-inbound-agent#397 from go…
d918a75 
…unthar/jdk21-preview

feat(jdk): Add preview images for jdk21
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
@gounthar @lemeurherve
[PATCH] Merge pull request jenkinsci/docker-inbound-agent#397 from go…
18f225a 
…unthar/jdk21-preview

feat(jdk): Add preview images for jdk21
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
@gounthar @lemeurherve
[PATCH] Merge pull request jenkinsci/docker-inbound-agent#397 from go…
895fbbc 
…unthar/jdk21-preview

feat(jdk): Add preview images for jdk21
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
@gounthar @lemeurherve
[PATCH] Merge pull request jenkinsci/docker-inbound-agent#397 from go…
25c6a86 
…unthar/jdk21-preview

feat(jdk): Add preview images for jdk21
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Jan 12, 2024
@dduportal
Merge pull request jenkinsci/docker-inbound-agent#397 from gounthar/j…
c9c4e5b 
…dk21-preview

feat(jdk): Add preview images for jdk21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timja timja timja approved these changes

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
enhancement jdk21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add alpine arm64 docker image builds
3 participants
@gounthar @dduportal @timja