Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a mix of make and docker calls in the Jenkinsfile #420

Closed
lemeurherve opened this issue Jun 9, 2024 · 1 comment
Closed

There is a mix of make and docker calls in the Jenkinsfile #420

lemeurherve opened this issue Jun 9, 2024 · 1 comment
Labels

Comments

@lemeurherve
Copy link
Member

lemeurherve commented Jun 9, 2024

Jenkins and plugins versions report

N/A

What Operating System are you using (both controller, and any agents involved in the problem)?

N/A

Reproduction steps

  1. Notice that there is a mix of make and docker calls in the Jenkinsfile.

Expected Results

The calls to either make or docker are consistent and justified.

Actual Results

The first call to docker makes sense as it's specific to our CI environment, having it outside the Makefile doesn't prevent contributors to build images on their own.

docker buildx create --use
docker run --rm --privileged multiarch/qemu-user-static --reset -p yes

The next ones don't though, they should be calls to make targets that can also be used by contributors on their own.

sh 'make build'
sh 'make test'
// If the tests are passing for Linux AMD64, then we can build all the CPU architectures
sh 'docker buildx bake --file docker-bake.hcl linux'

export ON_TAG=true
export VERSION=$TAG_NAME
docker buildx bake --push --file docker-bake.hcl linux

Anything else?

No response

Are you interested in contributing a fix?

Yes:

@lemeurherve
Copy link
Member Author

Confirmed working with https://github.com/jenkinsci/docker-ssh-agent/releases/tag/5.41.0 built completed on trusted.ci.jenkins.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant