You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What Operating System are you using (both controller, and any agents involved in the problem)?
N/A
Reproduction steps
Notice that there is a mix of make and docker calls in the Jenkinsfile.
Expected Results
The calls to either make or docker are consistent and justified.
Actual Results
The first call to docker makes sense as it's specific to our CI environment, having it outside the Makefile doesn't prevent contributors to build images on their own.
Jenkins and plugins versions report
N/A
What Operating System are you using (both controller, and any agents involved in the problem)?
N/A
Reproduction steps
make
anddocker
calls in the Jenkinsfile.Expected Results
The calls to either
make
ordocker
are consistent and justified.Actual Results
The first call to
docker
makes sense as it's specific to our CI environment, having it outside the Makefile doesn't prevent contributors to build images on their own.docker-ssh-agent/Jenkinsfile
Lines 48 to 49 in 2985d6f
The next ones don't though, they should be calls to make targets that can also be used by contributors on their own.
docker-ssh-agent/Jenkinsfile
Lines 61 to 64 in 2985d6f
docker-ssh-agent/Jenkinsfile
Lines 87 to 89 in 2985d6f
Anything else?
No response
Are you interested in contributing a fix?
Yes:
docker
calls asmake
targets #421The text was updated successfully, but these errors were encountered: