Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement docker calls as make targets #421

Merged
merged 7 commits into from
Jun 18, 2024

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Jun 9, 2024

This PR replaces docker calls by make ones so there isn't an unjustified mix of these commands calls anymore and so that everything can be done via make commands from CI or locally. (Doc added)

Fixes:

Extracted from:

Testing done

CI

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@lemeurherve lemeurherve added the bug label Jun 9, 2024
@lemeurherve lemeurherve requested a review from a team as a code owner June 9, 2024 18:18
@lemeurherve lemeurherve changed the title fix: replace docker calls by make ones fix: implement docker calls as make targets Jun 9, 2024
@lemeurherve lemeurherve force-pushed the issue420-use-make-targets branch from 211533b to 6c1c766 Compare June 9, 2024 19:50
timja
timja previously approved these changes Jun 9, 2024
dduportal
dduportal previously approved these changes Jun 18, 2024
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few nits thanks!

Jenkinsfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Jenkinsfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
@lemeurherve lemeurherve dismissed stale reviews from dduportal and timja via f4cedda June 18, 2024 09:44
@lemeurherve lemeurherve requested a review from dduportal June 18, 2024 10:24
@lemeurherve
Copy link
Member Author

lemeurherve commented Jun 18, 2024

Self-merging as the pull request has been previously approved and the nits have been discussed and resolved.

@lemeurherve lemeurherve merged commit 8e82638 into jenkinsci:master Jun 18, 2024
9 checks passed
@lemeurherve lemeurherve deleted the issue420-use-make-targets branch June 18, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants