Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests) use bats junit direct exporter to get rid of NodeJS and NPM #344

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Nov 13, 2023

Since v1.6.0, the CLI bats is able to export the test results directly to junit format.

It's a good opportunity to get rid of both NodeJS and NPM from this repository which were only used to export results from the default TAP fomrat to Junit.

Note this PR bumps bats from 1.7.0 to 1.10.0 to benefit from the formatter bugfixes and ensure Junit format errors.


We can close unneeded PRs around NodeJS/NPM:

Closes #342
Closes #324

Testing done

  • Ran tests locally and checked the directory target contains Junit XML results
  • Let's check the CI result: we want Jenkins to properly parse the Junit XML files

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…NPM)

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal changed the title Chore/tests/use bats junit chore(tests) use bats junit direct exporter to get rid of NodeJS and NPM Nov 13, 2023
@dduportal dduportal marked this pull request as ready for review November 13, 2023 16:58
@dduportal dduportal requested a review from a team as a code owner November 13, 2023 16:58
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Very nice improvement

@MarkEWaite MarkEWaite merged commit 6a8baf1 into jenkinsci:master Nov 13, 2023
3 checks passed
@dduportal dduportal deleted the chore/tests/use-bats-junit branch November 13, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants