Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused build.ps1 Build parameter and commented line #425

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Jun 15, 2024

This PR removes this unused build.ps1 Build parameter:

Param(
[Parameter(Position=1)]
[String] $Target = 'build',
[String] $Build = '',

And a commented line that I should have removed from #289 when adapting from docker-agent build process (where setting this path is needed as there is a tests suite per type of agent):

# $configuration.Run.Path = 'tests\sshAgent.Tests.ps1'

Testing done

Local test + CI

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit a1b4f75 into master Jun 17, 2024
10 checks passed
@MarkEWaite MarkEWaite deleted the chore-remove-build-parameter branch June 17, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants