remove demo requirement for release

[car-roll]

Demo is not using the latest release tags. Does not seem to be critical for releasing plugin

[dwnusbaum]

If you do this I would add a prominent notice to the top of demo/README.md that it is outdated and kept only as a reference, or maybe go ahead and delete the demo directory entirely and add a link to the top-level README that says something like "There is an outdated demo of this functionality here", and have it link to the demo folder as of tag docker-workflow-1.12 which seems to be the last time it was updated.

[jglick]

Wait why are you deleting the demo?

[car-roll]

@jglick It appeared to be stuck at version 1.12 and there were some issues I had in getting it working with the latest snapshot. If you prefer, I can add it back in and just add in a note mentioning that it's on 1.12 in the README

[jglick]

there were some issues I had in getting it working with the latest snapshot

This is what I was missing. Up to you I guess. While maintaining this plugin I kept the demo running as a useful way to see the functionality working end-to-end in a semirealistic context. (Some artificialities around using docker.sock but using a real authenticated registry, etc.)

[jglick]

add it back in and just add in a note mentioning that it's on 1.12

No, that would be useless. My request would have been to fix the demo, unless there something fundamentally broken that could not be resolved without a lot of work.