Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Additional Docker Run Arguments #308

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lenaing
Copy link

@lenaing lenaing commented Nov 2, 2023

Why this pull request ?

This pull request enable Jenkins adminstrator (or users) to add specific arguments to each docker run commands issued by the plugin to the underlying Docker Pipeline node.

Context

At $daywork, we are migrating from an old DCOS infrastructure, with DIND containers having access to the Docker Socket, to Kubernetes DIND containers (without Docker Socket access).

DCOS DIND containers automatically remount all volumes, including a TLS CA bundle that is provided to the Docker Pipeline Node.
On Kubernetes, the volumes is not found (as there is no volume found for the container exposed through the DIND without a shared socket), so we needed a way to append specific args to each docker run command as such : -v /etc/ssl/certs/tls-ca-bundle.pem:/etc/ssl/certs/tls-ca-bundle.pem:ro,z (The TLS CA bundle is exposed to the DIND container by Kubernetes through a config map).

This enable us to migrate our infrastructure without having to ask our numerous users to append an "args: ..." to all of their pipelines' code.

Testing done

Modified current tests to check for Global and Folder config / overrides.

Currently opened to our internal user base in beta befor pushing to our production infrastructure.

Submitter checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant