Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default value of Jenkins version #1411

Merged
merged 7 commits into from
Jun 26, 2022
Merged

Conversation

basil
Copy link
Member

@basil basil commented Jun 26, 2022

#1409 set the default set the value of this to 2.356 in docker-bake.hcl, but the individual Dockerfiles still have an old version. This PR makes the version consistent throughout the repository.

@basil basil requested review from olivergondza and a team as code owners June 26, 2022 18:26
@timja timja enabled auto-merge (squash) June 26, 2022 18:47
@basil
Copy link
Member Author

basil commented Jun 26, 2022

Looks like there is a test failure in the last three tests of tests/runtime.Tests.ps1.

@basil
Copy link
Member Author

basil commented Jun 26, 2022

Looks like the same fix to the Get-Csp-Value and Get-Timezone-Value functions as was done in f471a2f needs to be done to the corresponding copypasta in runtime.Tests.ps1.

auto-merge was automatically disabled June 26, 2022 19:39

Head branch was pushed to by a user without write access

@basil
Copy link
Member Author

basil commented Jun 26, 2022

I tried to port the corresponding logic from f471a2f to runtime.Tests.ps1, but this is the first time in my life that I have ever written a .ps1 script, so I would be shocked if I got it right on the first try.

@timja timja enabled auto-merge (squash) June 26, 2022 19:43
auto-merge was automatically disabled June 26, 2022 20:36

Head branch was pushed to by a user without write access

@timja timja enabled auto-merge (squash) June 26, 2022 20:38
auto-merge was automatically disabled June 26, 2022 21:06

Head branch was pushed to by a user without write access

@timja timja enabled auto-merge (squash) June 26, 2022 21:07
auto-merge was automatically disabled June 26, 2022 21:13

Head branch was pushed to by a user without write access

@timja timja enabled auto-merge (squash) June 26, 2022 21:21
@timja timja merged commit 4d817e0 into jenkinsci:master Jun 26, 2022
@basil basil deleted the jenkins-version branch June 26, 2022 21:28
dduportal pushed a commit to dduportal/docker that referenced this pull request Aug 18, 2022
* Update default value of Jenkins version

* Try and fix tests

* Fix ps1

* Minimize diff

* Remove HTML from regex

* facepalm

(cherry picked from commit 4d817e0)
dduportal pushed a commit to dduportal/docker that referenced this pull request Aug 18, 2022
* Update default value of Jenkins version

* Try and fix tests

* Fix ps1

* Minimize diff

* Remove HTML from regex

* facepalm

(cherry picked from commit 4d817e0)
dduportal pushed a commit to dduportal/docker that referenced this pull request Aug 25, 2022
* Update default value of Jenkins version

* Try and fix tests

* Fix ps1

* Minimize diff

* Remove HTML from regex

* facepalm

(cherry picked from commit 4d817e0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants