-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: Update default jenkins version to 2.410 #1656
Windows: Update default jenkins version to 2.410 #1656
Conversation
Update default jenkins version
Hi @dduportal , @timja - is there anything else required to get this merged? Perhaps all the default versions should be bumped at the same time (like in commit 4d817e0)? |
Hi @Jonny-vb Thansk for this PR! It make sense to fix "now" and change the default value to all Dockerfile:
Are you ok to do this here? |
Hi @dduportal - yep makes sense - additional changes made. I realised the source branch name doesn't make sense now either though - is that okay or do you want me to create a new PR with a better name? |
No worries about the soure branch name. The PR title is the important thing as it will be both commit and changelog message once merged. thanks for the change ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Thanks for merging - one last thing - what actually triggers the builds? I have a feeling that might rely on a new jenkins tag being published, which means a wait until this change gets through to the windows docker image. Is there any change it could be manually started to get this through? |
Hi @Jonny-vb you are correct, since #1630 the builds are triggered when a tag is created, during Jenkins releases. Once we'll fix the full windows build, though, we should be able to run a few manual builds to only build latest Weekly and LTS (but we need a fully fixed build first). |
Just to confirm that the new windows image has been published using 2.410 as intended. |
Oooh cool you rock ! Thanks for confirmation. I’ll bring this subject to the platform SIG meeting today to pave the way for next steps |
Update default jenkins version.
Based on #1490 the windows docker version is lagging behind.

The current version provided (2.356) gives the following issues:
So this is a quick fix to resolve the vulnerabilities in the current issue, before any work is done to actually fix the build process.
Testing done
Submitter checklist