Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Update default jenkins version to 2.410 #1656

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Windows: Update default jenkins version to 2.410 #1656

merged 3 commits into from
Jun 19, 2023

Conversation

Jonny-vb
Copy link
Contributor

@Jonny-vb Jonny-vb commented Jun 15, 2023

Update default jenkins version.

Based on #1490 the windows docker version is lagging behind.
The current version provided (2.356) gives the following issues:
image

So this is a quick fix to resolve the vulnerabilities in the current issue, before any work is done to actually fix the build process.

Testing done

Submitter checklist

Preview Give feedback

Update default jenkins version
@Jonny-vb Jonny-vb requested a review from a team as a code owner June 15, 2023 11:32
@dduportal dduportal self-assigned this Jun 19, 2023
@Jonny-vb
Copy link
Contributor Author

Hi @dduportal , @timja - is there anything else required to get this merged? Perhaps all the default versions should be bumped at the same time (like in commit 4d817e0)?
If not I am keen to get this merged so that I can remove the long standing warnings I've had on my instance!

@dduportal
Copy link
Contributor

Hi @Jonny-vb Thansk for this PR!

It make sense to fix "now" and change the default value to all Dockerfile:

  • For coherency between Linux and Windows images
  • To ensure all Windows images are updated at once (all available JDK and Windows distributions)

Are you ok to do this here?

@Jonny-vb
Copy link
Contributor Author

Hi @dduportal - yep makes sense - additional changes made. I realised the source branch name doesn't make sense now either though - is that okay or do you want me to create a new PR with a better name?

@Jonny-vb Jonny-vb changed the title Update windows Dockerfile default jenkins version Update Dockerfile default jenkins version Jun 19, 2023
@dduportal
Copy link
Contributor

No worries about the soure branch name. The PR title is the important thing as it will be both commit and changelog message once merged.

thanks for the change !

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@dduportal dduportal merged commit ff84b2b into jenkinsci:master Jun 19, 2023
@dduportal dduportal added chore and removed bug labels Jun 19, 2023
@dduportal dduportal changed the title Update Dockerfile default jenkins version Windows: Update default jenkins version to 2.410 Jun 19, 2023
@Jonny-vb Jonny-vb deleted the feature/update-windows-version branch June 19, 2023 12:42
@Jonny-vb
Copy link
Contributor Author

Thanks for merging - one last thing - what actually triggers the builds? I have a feeling that might rely on a new jenkins tag being published, which means a wait until this change gets through to the windows docker image. Is there any change it could be manually started to get this through?

@dduportal
Copy link
Contributor

Thanks for merging - one last thing - what actually triggers the builds? I have a feeling that might rely on a new jenkins tag being published, which means a wait until this change gets through to the windows docker image. Is there any change it could be manually started to get this through?

Hi @Jonny-vb you are correct, since #1630 the builds are triggered when a tag is created, during Jenkins releases.
As they are no such thing as "latest available image", and since the process should not rebuild a given tag, you'll have to wait tomorrow's weekly release to see the image published.

Once we'll fix the full windows build, though, we should be able to run a few manual builds to only build latest Weekly and LTS (but we need a fully fixed build first).

@Jonny-vb
Copy link
Contributor Author

Just to confirm that the new windows image has been published using 2.410 as intended.

@dduportal
Copy link
Contributor

Just to confirm that the new windows image has been published using 2.410 as intended.

Oooh cool you rock ! Thanks for confirmation. I’ll bring this subject to the platform SIG meeting today to pave the way for next steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants