-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking(linux) Update debian images to bookworm #1687
Conversation
@@ -1,5 +1,5 @@ | |||
ARG JAVA_VERSION="11.0.20_8" | |||
ARG BULLSEYE_TAG=20230725 | |||
ARG BOOKWORM_TAG=20230725 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be better to use a new tag, 20230814
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pointer!
That change will be applied automatically once merged thanks to the updatecli
manifest.
It will prove that the automation system continue working as expected :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1688 => ✅ 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The usual CI checks are working as expected
- Built locally and I have a working image for JDK17
- Please note that the updatecli check is not required: it fails in the PR but should works once merged and we expect an automated PR which will update the debian version
@timja I'll let you merge once you're happy with the change / approval |
Fixes #1686
Testing done
Built one of the images locally and checked it was using bookworm
Submitter checklist