Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(jdk21-preview): don't hardcode JAVA_MAJOR_VERSION in release URL #1753

Merged
merged 2 commits into from
Oct 24, 2023
Merged

chore(jdk21-preview): don't hardcode JAVA_MAJOR_VERSION in release URL #1753

merged 2 commits into from
Oct 24, 2023

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Oct 23, 2023 •
edited
Loading

This PR removes hardcoded JAVA_MAJOR_VERSION in preview (EA) release download URL for jdk21-preview images.

Related: jenkinsci/docker-agent#538

Testing done

https://ci.jenkins.io/job/Packaging/job/docker/job/PR-1753/1/

Submitter checklist
Preview Give feedback

@lemeurherve lemeurherve marked this pull request as ready for review October 23, 2023 15:55
@lemeurherve lemeurherve requested review from ksalerno99 and a team as code owners October 23, 2023 15:55
@lemeurherve lemeurherve enabled auto-merge (squash) October 24, 2023 08:57
@lemeurherve lemeurherve merged commit d818fc7 into jenkinsci:master Oct 24, 2023
@lemeurherve lemeurherve deleted the chore-dont-hardcode-java-major-version branch October 24, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

@ksalerno99 ksalerno99 Awaiting requested review from ksalerno99 ksalerno99 is a code owner

Assignees
No one assigned
Labels
chore debian jdk21-preview rhel/ubi9 skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lemeurherve @dduportal