Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convenient methods to override dynamic ATX settings #100

Merged
merged 4 commits into from
Nov 10, 2019
Merged

Convenient methods to override dynamic ATX settings #100

merged 4 commits into from
Nov 10, 2019

Conversation

cpoenisch
Copy link
Contributor

Resolves #98

@cpoenisch
allow to override ATX settings via named args and using override method
bac4cb7 
- additional whitelisted getters for discovering current settings
- simplified extracting parts of full server URL
- add integration pipeline tests
@cpoenisch cpoenisch added feature New feature request test-guide labels Oct 22, 2019
@cpoenisch cpoenisch added this to the 2.12.0 milestone Oct 22, 2019
@cpoenisch cpoenisch self-assigned this Oct 22, 2019
@cpoenisch
allow to override ATX settings via named args and using override method
4b5e20d 
- additional whitelisted getters for discovering current settings
- simplified extracting parts of full server URL
- add integration pipeline tests
@cpoenisch
Merge branch 'i98-atx-override' of https://github.com/jenkinsci/ecute…
f95d98f 
…st-plugin into i98-atx-override
@cpoenisch
update code snippets
e0a2102
@S3-D1 S3-D1 self-requested a review November 10, 2019 15:41
@S3-D1 S3-D1 merged commit 96d30d2 into master Nov 10, 2019
S3-D1
S3-D1 reviewed Nov 10, 2019
View reviewed changes
Copy link

@S3-D1 S3-D1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • changes accepted

@cpoenisch cpoenisch deleted the i98-atx-override branch November 15, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S3-D1 S3-D1 S3-D1 left review comments

Assignees

@cpoenisch cpoenisch

Labels
feature New feature request
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

Convenient methods to override dynamic ATX settings
2 participants
@cpoenisch @S3-D1