Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hint and error text for backslash #510

Merged
12 commits merged into from
Jan 9, 2023
Merged

Add hint and error text for backslash #510

12 commits merged into from
Jan 9, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2022 •
edited by ghost
Loading

Resolves #497

@ghost ghost linked an issue Dec 13, 2022 that may be closed by this pull request
Add hint and error text for backslash #497
Closed
@ghost ghost self-assigned this Dec 13, 2022
ErikRehmTT
ErikRehmTT requested changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@ErikRehmTT ErikRehmTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I thought, we add a hint directly under the input field, where a single backslash was detected, instead of just putting it into the help.

README.md Show resolved Hide resolved
src/main/java/de/tracetronic/jenkins/plugins/ecutest/test/client/AbstractTestClient.java Outdated Show resolved Hide resolved
src/main/java/de/tracetronic/jenkins/plugins/ecutest/test/client/AbstractTestClient.java Outdated Show resolved Hide resolved
src/main/java/de/tracetronic/jenkins/plugins/ecutest/test/client/PackageClient.java Outdated Show resolved Hide resolved
ErikRehmTT
ErikRehmTT reviewed Dec 16, 2022
View reviewed changes
Copy link
Collaborator

@ErikRehmTT ErikRehmTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some CheckStyle findings, which should be resolved. Everything else looks fine for me now.

@ghost ghost merged commit 72764b2 into master Jan 9, 2023
@ghost ghost deleted the i497_add-hint-and-error-text-for-backslash branch January 9, 2023 14:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hint and error text for backslash
1 participant
@ErikRehmTT