🚀 Adapt to changes from credentials regarding password length in FIPS mode #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode jenkinsci/credentials-plugin#558 Signed-off-by: Olivier Lamy <olamy@apache.org>
jonesbusy
approved these changes
Sep 18, 2024
pankajy-dev
reviewed
Sep 18, 2024
| @@ -126,6 +126,7 @@ | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>credentials</artifactId> | |||
| <version>1378.v81ef4269d764</version> | |||
There was a problem hiding this comment.
Why are we providing the version here?
There was a problem hiding this comment.
just need to force version containing this change jenkinsci/jenkins-test-harness#829
There was a problem hiding this comment.
not sure I follow, if you want that change, then change the property jenkins-test-harness.version?
do you mean that you want a version containing jenkinsci/credentials-plugin#558 instead?
jtnord
reviewed
Sep 18, 2024
| @@ -126,6 +126,7 @@ | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>credentials</artifactId> | |||
| <version>1378.v81ef4269d764</version> | |||
There was a problem hiding this comment.
not sure I follow, if you want that change, then change the property jenkins-test-harness.version?
do you mean that you want a version containing jenkinsci/credentials-plugin#558 instead?
Co-authored-by: James Nord <jtnord@users.noreply.github.com>
jtnord
approved these changes
Sep 18, 2024
|
@jenkinsci/email-ext-plugin-developers any volunter to merge this to get a release? Thanks |
slide
approved these changes
Sep 24, 2024
slide
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olivier Lamy olamy@apache.org
Testing done
Submitter checklist