Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to commons-digester3 #11

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Conversation

car-roll
Copy link
Contributor

Upgrade to commons-digester3. downstream of jenkinsci/jenkins#5320

ping @daniel-beck

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link

@marek-parfianowicz marek-parfianowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a similar change in the Clover plugin (see jenkinsci/clover-plugin#24), the following snippet was added:

            try {
                digester.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true);
                digester.setFeature("http://xml.org/sax/features/external-general-entities", false);
                digester.setFeature("http://xml.org/sax/features/external-parameter-entities", false);
                digester.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false);
            } catch (ParserConfigurationException ex) {
                throw new SAXException("Failed to securely configure xml digester parser", ex);
            }```

I do not see such fragment in this PR for the emma plugin.

@car-roll car-roll force-pushed the commons-digester3 branch from 490fec1 to 32c9070 Compare April 30, 2021 22:59
@car-roll
Copy link
Contributor Author

car-roll commented May 1, 2021

@marek-parfianowicz you're right, that section of code has been added

Copy link

@marek-parfianowicz marek-parfianowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

@batmat batmat requested review from MRamonLeon, rsandell and alecharp May 3, 2021 10:08
@batmat batmat merged commit d44da49 into jenkinsci:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants