Add compact average duration column in minutes #16
Conversation
ssbarnea
force-pushed
the
compact-duration
branch
from
a976493 to
242f10d
Compare
|
You can see here how the new column looks: I also has a tooltip with the long name, making it accessible. |
| <url>http://repo.jenkins-ci.org/public/</url> | ||
| </pluginRepository> | ||
| </pluginRepositories> | ||
|
|
There was a problem hiding this comment.
The repositories are already contained in the parent POM, so there is no need to redefine them.
There was a problem hiding this comment.
Hmm, I guess I missed something but without these lines mvn package fails to build. Only with these lines it the project will build.
See https://gist.github.com/ssbarnea/5e7afb65cf4db3885c9814d2ed657cca
I think that you did not encounter these errors because your did pre-customize your mvn config.
There was a problem hiding this comment.
You are right. I have defined it in my Maven settings.xml. This is recommended, see https://wiki.jenkins-ci.org/display/JENKINS/Plugin+tutorial#Plugintutorial-SettingUpEnvironment
| @@ -31,5 +31,8 @@ THE SOFTWARE. | |||
| <j:when test="${it.getBuildDurationType()==1}"> | |||
| <th>${%Average Duration}</th> | |||
| </j:when> | |||
| <j:when test="${it.getBuildDurationType()==2}"> | |||
| <th title="${%Average duration in minutes (compact)}">⏳'</th> | |||
There was a problem hiding this comment.
At least in Jenkins version 1.580 there is no support for Unicode/Emojis. So I'd recommend to add the image instead.
There was a problem hiding this comment.
@fredg02 I am really curious what makes older Jenkins incompatible with Unicode Emojis? As far as I know is only Unicode.
There was a problem hiding this comment.
My assumption was wrong. It does not depend on the Jenkins version. It depends on your browser and font. It doesn't work at all for me in the current form. If I use the corresponding HTML entity in either hex or decimal, I can see at least a black and white(!) hour glass in Chrome, but nothing in Firefox. I don't know if there are other ways to do it, but I'd still recommend to use an image.
Which browser do you use? Is there a special reason why you want to use the unicode character?
|
Thanks for the pull-request! 👍 If you could fix the two minor issues (mentioned above), I will be happy to merge it. |
No description provided.