Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese translation #19

Merged
merged 1 commit into from
Jan 8, 2018
Merged

Add Chinese translation #19

merged 1 commit into from
Jan 8, 2018

Conversation

LinuxSuRen
Copy link
Member

No description provided.

@LinuxSuRen
Copy link
Member Author

LinuxSuRen commented Jan 3, 2018

@larrys Anyone help to review this pr?

@larrys
Copy link
Member

larrys commented Jan 5, 2018

@LinuxSuRen I no longer maintain this plugin. You will need to ping @i386 possibly.

@LinuxSuRen
Copy link
Member Author

@larrys Thanks for your tip, @i386 Can you help to review this?

@i386
Copy link
Contributor

i386 commented Jan 7, 2018

Ive asked for help on the mailing list to review https://groups.google.com/forum/?nomobile=true#!topic/jenkinsci-dev/SsC6vQg4k-I

@LinuxSuRen
Copy link
Member Author

Thank you, I can not visit google website. @i386

@daniel-beck
Copy link
Member

@i386 FYI the author has contributed quite a few Chinese translations to core in the past: https://github.com/jenkinsci/jenkins/pulls?q=is%3Apr+author%3Alinuxsuren+is%3Aclosed

I usually check some HTML file translations in Google translate, and they all seemed reasonable. So if @LinuxSuRen is out to mess with us, they've already gotten into core 🤷‍♂️

@i386
Copy link
Contributor

i386 commented Jan 8, 2018

SGTM

@i386 i386 merged commit a70021f into jenkinsci:master Jan 8, 2018
@ijyun
Copy link

ijyun commented Jan 9, 2018

@i386 Hi James,I could help to translate into Chinese.I'm wondering is the requirement is to translate the README.md file? there is not much notice, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants