Provide affected lines for code delta #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
============================================
+ Coverage 68.44% 68.74% +0.29%
- Complexity 365 369 +4
============================================
Files 48 48
Lines 1160 1171 +11
Branches 100 100
============================================
+ Hits 794 805 +11
Misses 325 325
Partials 41 41
Continue to review full report at Codecov.
|
uhafner
requested changes
Mar 9, 2022
| public Change(final ChangeEditType changeEditType, final int fromLine, final int toLine) { | ||
| this.changeEditType = changeEditType; | ||
| this.fromLine = fromLine; | ||
| this.toLine = toLine; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
Use this(...) to initialize the deprecated constructor
| Change change = createChange(); | ||
| assertThat(change.getEditType()).isEqualTo(EDIT_TYPE); | ||
| assertThat(change.getChangedFromLine()).isEqualTo(CHANGED_FROM_LINE); |
There was a problem hiding this comment.
It would be more fluent if you could use the custom assertions. So:
Suggested change
| assertThat(change.getChangedFromLine()).isEqualTo(CHANGED_FROM_LINE); | |
| assertThat(change).hasChangedFromLine(CHANGED_FROM_LINE) | |
| .hasChangedToLine(...) | |
| ...; |
uhafner
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expanded the code delta API that it also provides the affected lines, which will be changed by a new commit, as they were before the change has been made.