Do not use synchronised checks during event processing #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using synchronised checks during event processing leads to contention on GerritWorker threads. Especially if lock is done on ToGerritRunListener. So, to speed up the processing we need to get rid of `isProjectTriggeredAndIncomplete`. `isProjectTriggeredAndIncomplete` can be replaced by `isTriggered` and `isBuilding`. That transforms the previos version of check to `(isTriggered && isBuilding) || isTriggered`. So, it's absolutely safe to keep `isTriggered` only. After that plugin itself does not use `isProjectTriggeredAndIncomplete`.
Skaiol
approved these changes
May 16, 2018
Parallel triggering of multiple jobs for the same event should not produce any issues as there is synchronization in onStarted method as well. But in same time onTriggered also is part of initial event processing. That's why it's important to not have a lock here.
Jimilian
force-pushed
the
remove_contention_on_event_processing
branch
from
e922ff2 to
37b2b42
Compare
rsandell
reviewed
Jul 10, 2018
| //TODO stop builds for earlier patch-sets on same change. | ||
| memory.triggered(event, project); | ||
| if (event instanceof GerritEventLifecycle) { | ||
| ((GerritEventLifecycle)event).fireProjectTriggered(project); | ||
| } | ||
| //Logging | ||
| String name = null; |
| @@ -328,18 +332,13 @@ protected void cleanUpGerritCauses(GerritCause firstFound, Run build) { | |||
| * @param project the project that will be built. | |||
| * @param event the event that caused the build to be scheduled. | |||
| */ | |||
| public synchronized void onTriggered(Job project, GerritTriggeredEvent event) { | |||
| public void onTriggered(Job project, GerritTriggeredEvent event) { | |||
| //TODO stop builds for earlier patch-sets on same change. | |||
| memory.triggered(event, project); | |||
| if (event instanceof GerritEventLifecycle) { | |||
There was a problem hiding this comment.
This is a change that might have outside repercussions. The lifecycle listeners might have assumptions about owning the monitor when called (which is normal behavior in most listener cases that I've seen)
But I think I can live with that risk if this change is really needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using synchronised checks during event processing leads to contention on
GerritWorker threads. Especially if lock is done on ToGerritRunListener.
So, to speed up the processing we need to get rid of
isProjectTriggeredAndIncomplete.isProjectTriggeredAndIncompletecan be replaced byisTriggeredandisBuilding.That transforms the previos version of check to
(isTriggered && isBuilding) || isTriggered.So, it's absolutely safe to keep
isTriggeredonly.After that plugin itself does not use
isProjectTriggeredAndIncomplete.Screenshot that shows that we were waiting for 2 minutes to parse 4 events.
