Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move repository browser commit link generation into git-plugin #241

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Feb 27, 2021

Creation of commit links currently is done in the git-forensics plugin by accessing some internal API methods. It makes much more sense to move these methods to the git plugin itself.

This PR depends on jenkinsci/git-plugin#1034 which has been released in git-4.10.0.

@uhafner uhafner added the internal Internal changes without user or API impact label Feb 27, 2021
@codecov
Copy link

codecov bot commented Nov 7, 2021

Codecov Report

Merging #241 (a0203b7) into master (59e1897) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #241      +/-   ##
============================================
- Coverage     80.76%   80.64%   -0.12%     
  Complexity      162      162              
============================================
  Files            22       22              
  Lines           681      677       -4     
  Branches         73       73              
============================================
- Hits            550      546       -4     
  Misses          104      104              
  Partials         27       27              
Impacted Files Coverage Δ
...plugins/forensics/git/util/GitCommitDecorator.java 50.00% <100.00%> (-12.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59e1897...a0203b7. Read the comment docs.

@uhafner uhafner merged commit 78586b0 into master Nov 7, 2021
@uhafner uhafner deleted the git-commit-decorator branch November 7, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes without user or API impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant