Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Commit Statistics Portlet for Pull Request Monitoring Plugin #314

Closed

Conversation

simonsymhoven
Copy link
Member

Provide a portlet for the pull request monitoring plugin. I used the new CommitStatisticsBuildAction and the corresponding CommitStatistics of PR-303 to deliver one portlet, only if a reference build is defined for the run:

Bildschirmfoto 2021-07-18 um 18 11 42

Bildschirmfoto 2021-07-18 um 18 12 10

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@uhafner
Copy link
Member

uhafner commented Aug 2, 2021

Can you please rebase? I updated all plugin dependencies now. I think some PMD warnings need to be fixed as well.

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking again at the sources I noticed that the change actually is not related to the Git implementation. It might be better suited for the forensics-api plugin. Then we can reuse the portlet for other repository implementations.

@simonsymhoven
Copy link
Member Author

After looking again at the sources I noticed that the change actually is not related to the Git implementation. It might be better suited for the forensics-api plugin. Then we can reuse the portlet for other repository implementations.

Yes that's true. I will implement these changes in the forensics-api-plugin and create a new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants